Skip to content

Conversation

@omergunal
Copy link
Contributor

@omergunal omergunal commented May 1, 2018

Created try_orelse_with_no_variables_to_save.py and try_orelse_with_no_variables_to_save_and_no_args.py for issue #62

omergunal added 2 commits May 2, 2018 00:56
created "test_try_orelse_with_no_variables_to_save_and_no_args"
@omergunal omergunal changed the title Created new tests Created new tests for cfg_test.py May 1, 2018
@KevinHock KevinHock self-requested a review May 2, 2018 01:52
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though feel free to change the line/dedent comment 👍

self.connected(ret_does_this_kill_us_3, print_so),
self.connected(print_so, print_good),
self.connected(print_good, _exit),

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this line and dedent the ]) to be on the same level as self.assertInCfg([.

try_ = 1
print_a5 = 2
except_im = 3
print_wagyu = 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't imagine like that :)

@KevinHock KevinHock merged commit 09edcb5 into python-security:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants